feat: add Context Menu to Runs view (ET-232) #9480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Keita Fish <[email protected]>
Co-authored-by: Keita Fish <[email protected]>
|
can we please add more test cases? the coverage is 67.66055% |
|
@keita-determined updated w more tests |
keita-determined
approved these changes
Jul 1, 2024
Comment on lines
170
to
175
| if (cell) { | ||
| if ('displayData' in cell && isString(cell.displayData)) { | ||
| return cell.displayData; | ||
| } | ||
| if (cell.copyData) return cell.copyData; | ||
| } |
There was a problem hiding this comment.
maybe we can simplify the code for the readability, but up to you
Suggested change
| if (cell) { | |
| if ('displayData' in cell && isString(cell.displayData)) { | |
| return cell.displayData; | |
| } | |
| if (cell.copyData) return cell.copyData; | |
| } | |
| if (cell && 'displayData' in cell && isString(cell.displayData)) { | |
| return cell.displayData; | |
| } | |
| if (cell && cell.copyData) return cell.copyData; |
Comment on lines
65
to
71
| if (cell) { | ||
| if ('displayData' in cell && isString(cell.displayData)) { | ||
| return cell.displayData; | ||
| } | ||
| if (cell.copyData) return cell.copyData; | ||
| } | ||
| return undefined; |
There was a problem hiding this comment.
can we fix the following warning?
Warning: An update to ForwardRef inside a test was not wrapped in act(...).
When testing, code that causes React state updates should be wrapped into act(...):
act(() => {
/* fire events that update state */
});
/* assert on the output */
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
ET-232
Description
Adds context menu (menu which appears on right-click of DataGrid cell) to Runs view.
This PR includes these actions in the menu:
This PR has changes from #9368 merged in. Planning not to merge this PR until that one is merged first. Should not actually include backend changes at that time. Code coverage numbers should hopefully also improve when the patch is only for context menu changes.
Most likely easier to review by looking at the diff between those two branches here: feature/actions-flat-run-table...ET-232
Test Plan
With permissions to modify, move, and delete experiments/runs:
Checklist
docs/release-notes/.See Release Note for details.